Incorrect handling of PAGE_FAULT_MASK

intel / DML

Intel® Data Mover Library (Intel® DML)

https://intel.github.io/DML/

MIT License

81 stars 17 forks source link

Closed jposwiata closed 8 months ago

jposwiata commented 9 months ago

The condition in core_interconnect.cpp:138 is incorrect. Should be:

if (is_finished && (status & 0x7f) == page_fault_mask)

(to get rid of READ/WRITE page fault bit, 0x80). Same in :107

abdelrahim-hentabli commented 9 months ago

Hey @jposwiata, thanks for opening this issue, and for sharing the fix as well. And great catch! We'll get this fixed ASAP!

abdelrahim-hentabli commented 9 months ago

Hey @jposwiata, thanks again for the issue, it should be fixed as of 673feec3d1a44351316845d90ff8f88df51904cc

mzhukova commented 8 months ago

Closing as resolved and no reply from the submitter for a month. @jposwiata please, feel free to re-open if needed.