search

intel / DML

Intel® Data Mover Library (Intel® DML)
https://intel.github.io/DML/
MIT License
81 stars 17 forks source link

Fix build on Windows: make libaccel_config.h be useable there #39

Closed thiagomacieira closed 3 months ago

thiagomacieira commented 9 months ago

Description

Without the declarations in it, we get a lot of build errors because the types aren't declared.

hardware_configuration_driver.h:56:39: warning: 'struct accfg_ctx' declared inside parameter list will not be visible outside of this definition or declaration
hw_configuration_driver.c:134:9: error: conflicting types for 'dsa_driver_new_context'; have 'int32_t(struct accfg_ctx **)' {aka 'int(struct accfg_ctx **)'}
hardware_configuration_driver.h:56:9: note: previous declaration of 'dsa_driver_new_context' with type 'int32_t(struct accfg_ctx **)' {aka 'int(struct accfg_ctx **)'}

hw_configuration_driver.c:188:21: error: return type is an incomplete type

etc.

Fixes #38.

No functional testing done. I've only confirmed that the build now succeeds on Windows, not even tried to run it there (it's not in scope for us at the moment).

No regression testing added because you don't have a public CI here on GitHub. Let me know once you add one and I'll add the MinGW build.

mzhukova commented 3 months ago

Hi @thiagomacieira, idxd-config is not supported on Windows, so the #if defined(__linux__) is expected. Could you please elaborate on what you're trying to do/address?

thiagomacieira commented 3 months ago

Hi @thiagomacieira, idxd-config is not supported on Windows, so the #if defined(__linux__) is expected. Could you please elaborate on what you're trying to do/address?

I know it's not supported. I just wanted the code to compile. But we've since given up and decided to bypass DML.

mzhukova commented 3 months ago

@thiagomacieira could you please elaborate more on the issue that you have with DML build or is it no longer relevant and we could close this PR?

thiagomacieira commented 3 months ago

I don't need DML any more, but the change is still valid, if DML is meant to be (ever) used on Windows.

mzhukova commented 3 months ago

Closing the PR as no longer relevant and since libaccel-config is not supported on Windows.