search

intel / Edge-Software-Provisioner

BSD 3-Clause "New" or "Revised" License
42 stars 31 forks source link

Please explain why you need to run anything as root #16

Open SvenDowideit opened 3 years ago

SvenDowideit commented 3 years ago

Don't run build scripts as root on the host. :)

SvenDowideit commented 3 years ago
  1. in build/buildUOS.sh a dind container is made with a bind mount to /tmp/builder/ to give the script access to the dind docker socket. (no indication on the build.sh output that its hung - see the output of builder.log
  2. and then that code crashes, trying to clean up the /tmp/builder/ dir.

Is there a reason for the ESP build process to hide what it downloaded and built in this step?

dvintel commented 3 years ago

Hi @SvenDowideit! There is nothing to hide, all the scripts are available to peruse and inspect. The folder is deleted since the contents are no longer needed.

If you have a suggestion of how we can make the build process better, we welcome pull/merge requests!

brod-intel commented 3 years ago

Don't run build scripts as root on the host. :)

Why not?

brod-intel commented 3 years ago
  1. in build/buildUOS.sh a dind container is made with a bind mount to /tmp/builder/ to give the script access to the dind docker socket. (no indication on the build.sh output that its hung - see the output of builder.log
  2. and then that code crashes, trying to clean up the /tmp/builder/ dir.

Is there a reason for the ESP build process to hide what it downloaded and built in this step?

Because this allows to do everything in a container. We only need Docker installed the host. That's it.