search

intel / Edge-Software-Provisioner

BSD 3-Clause "New" or "Revised" License
42 stars 31 forks source link

remove docker run interactive flag #31

Closed zhajianl closed 2 years ago

zhajianl commented 2 years ago

remove docker run interactive flag in order to let user do automation testing on host

dvintel commented 2 years ago

@brod-intel Is the interactive shell needed for "regular" use case?

zhajianl commented 2 years ago

@brod-intel Is the interactive shell needed for "regular" use case?

I was supposing that interactive shell only needed for debugging.

brod-intel commented 2 years ago

The problem with removing the -i (interactive) from docker run is you will not be able to hit "ctrl-c" to stop execution. The possibility of the services getting into an endless loop will happen. We have to have interactive with vpxe.sh. That must exist.

Please describe how the -i (interactive) prohibits automation testing?

zhajianl commented 2 years ago

interact

got it, thanks, we can abort this patch.