search

intel / FSP

Intel(R) Firmware Support Package (FSP)
Other
295 stars 127 forks source link

BroadwellDEFspBinPkg MR2 locks IA32_FEATURE_CONTROL in FSP-M #10

Open PatrickRudolph opened 5 years ago

PatrickRudolph commented 5 years ago

The IA32_FEATURE_CONTROL MSR is locked on all cores after memory init, but it should be locked in FspNotify(EnumInitPhaseReadyToBoot). That would allow coreboot to set sane values, instead of the FSP default of 0x4.

rminnich commented 5 years ago

that should never be locked by anything but the kernel. Anything else is a mistake. We went through this seven years ago on chromebooks, I can't believe we're back here.

PatrickRudolph commented 5 years ago

@nate-desimone Any update on this issue ?

shwong1 commented 5 years ago

The issue will be investigated, you may contact your Intel rep or file an IPS (Intel Premier Support) ticket if it’s urgent for you. Thanks!

PatrickRudolph commented 5 years ago

It's been a month without a reply. Any update on this issue ?

PatrickRudolph commented 5 years ago

It's been a month without a reply. Any update on this issue ?

lsiudut commented 5 years ago

At this point it's been a months. I'm +1-ning for update on that.

PatrickRudolph commented 5 years ago

It's been a month without a reply. Any update on this issue ?

PatrickRudolph commented 5 years ago

It's been a month without a reply. Any update on this issue ?

PatrickRudolph commented 4 years ago

Almost a year! You must be typing very slow as it's only one line of source code to change...

swong23 commented 4 years ago

Root cause : after memory initialization the FSP programs "IA32_FEATURE_CONTROL" MSR with Vmx features and lock the register by setting 0th bit; once the lock bit set the register become read only.

Proposed solution : do not lock the register after memory init instead lock the register during FSP ready to boot stage .

This will be resolved in the next official release however the timeline of next release is still tbc. For NDA customers and technology partners of Intel, you may contact your Intel Rep or file an IPS# ticket for source request or method consultation for temporary workaround on your own.

lynxis commented 2 years ago

@swong23 any update on this (next month this will be 3 years old)