search

intel / FSP

Intel(R) Firmware Support Package (FSP)
Other
288 stars 126 forks source link

Fixed bsf file and some typos #100

Closed memristor2 closed 6 months ago

memristor2 commented 7 months ago

I have fixed the bsf file for EagleStream so it can now be opened and edited with the Binary Configuration Tool and then patched to the FSP binary. Also the lowercase "s" in EagleStream was set to uppercase "S"

memristor2 commented 7 months ago

Resolves: https://github.com/intel/FSP/issues/99

nate-desimone commented 6 months ago

Hi @memristor2 - Thank you for your contribution!

Due to legal issues, we are unable to accept PRs from people who were not Intel employees at the time the PR was submitted. We appreciate your enthusiasm and thank you for your support.

memristor2 commented 6 months ago

Hi @nate-desimone, I understand this. I am waiting for the EagleStream patch in edk2-platforms. But since that is going to take a while I thought maybe issuing a PR would be a mere reminder for the fact that the EagleStream's FSP is incomplete. My saying is simply based on FSP External Architecture which states the FSP distrubition package must contain some things that I am not going to mention since Im sure that you are aware of it better than me. I was wondering if you could atleast relase the integration guide for EagleStream. Thanks

nate-desimone commented 6 months ago

Hi @memristor2 - I can confirm that several people at Intel including myself are working to resolve the concerns that you mention, and the concerns you bring up in this PR.