search

intel / FSP

Intel(R) Firmware Support Package (FSP)
Other
292 stars 127 forks source link

MP_SERVICES pointer is optional #47

Closed Th3Fanbus closed 6 months ago

Th3Fanbus commented 4 years ago

Hi,

As discussed on review.coreboot.org, looks like the MP_SERVICES pointer is not a requirement:

  1. The MP_SERVICES pointer is completely optional. You can set it to NULL and FSP will use its built-in MP implementation, which negates this whole argument. I am aware of several platforms that use coreboot with this set to NULL. It is the user's choice to configure coreboot in this way, not Intel's.

It would be nice to enhance the documentation with this additional information.

Thanks in advance,

Angel

nate-desimone commented 4 years ago

Hi @Th3Fanbus - 100% agreed, I'll work on updating the relevant integration guides.

nate-desimone commented 4 years ago

@Th3Fanbus, I've added some description text on CpuMpPpi to section 3.6.4 of the Coffee Lake FSP Integration Guide in eb25f19. Please take a look. I'm working on getting that added to the other Integration Guides now.

Th3Fanbus commented 4 years ago

@nate-desimone I've checked the newly-added section and it looks good. Thank you!

nate-desimone commented 6 months ago

Thanks for the feedback. Closing as it seems the issue is resolved.