intel / FSP

Intel(R) Firmware Support Package (FSP)
Other
292 stars 127 forks source link

ApolloLakeFspBinPkg[MR6] configures PCIe Root Port's DCTL[MPS] #56

Open n-huber opened 3 years ago

n-huber commented 3 years ago

FSP configures the effective Max Payload Size for PCIe Root Ports (and probably other integrated PCIe devices). This seems wrong, because only the OS drivers for PCIe devices know the target of transactions and can decide the maximum payload size on the route. Please fix that. Or add an option to FSP to disable its OS features. It's obvious that having unnecessary features in FSP only increases the amount of things that can go wrong (cf. #55). Such errors make the use of FSP much more expensive than a custom implementation.