intel / FSP

Intel(R) Firmware Support Package (FSP)
Other
295 stars 127 forks source link

KabylakeFspBinPkg may violate TCG PTP specification #62

Open benjamindoron opened 3 years ago

benjamindoron commented 3 years ago

The TCG PTP specification requires TPMs without CapCRBIdleBypass to start in tpmIdle and be returned to tpmIdle after command completion. However, at least Intel PTT (TPM 2.0 PTP CRB without CapCRBIdleBypass) is left in cmdReady.

This was discovered on https://review.coreboot.org/c/coreboot/+/48329 with a workaround displaying the issue in https://github.com/benjamindoron/edk2_coreboot-dev/commit/976f90afd96b5ce4d8618be1187dd3679096d420.