intel / FSP

Intel(R) Firmware Support Package (FSP)
Other
288 stars 126 forks source link

Alder Lake S IOT FSP package has missing headers #83

Closed miczyg1 closed 1 year ago

miczyg1 commented 2 years ago

The Include directory is missing MemInfoHob.h and FirmwareVersionInfoHob.h files.

nate-desimone commented 2 years ago

I included them in the client release:

https://github.com/intel/FSP/blob/master/AlderLakeFspBinPkg/Client/AlderLakeS/Include/MemInfoHob.h https://github.com/intel/FSP/blob/master/AlderLakeFspBinPkg/Client/AlderLakeS/Include/FirmwareVersionInfoHob.h

As long as the IoT owners approve I can copy those over to the IoT folder as well.

miczyg1 commented 2 years ago

@nate-desimone WOW, the Client FSP is already here! That's great.

I also have contacted our FAE to include these files, but apparently MemInfoHob.h is confidential, which is confusing to me. Especially when Slimbootloader has the file present on public repo: https://github.com/slimbootloader/slimbootloader/blob/master/Silicon/AlderlakePkg/Include/MemInfoHob.h (although I have no means to confirm it is sourced from IOT FSP).

nate-desimone commented 2 years ago

@miczyg1, the response from your FAE makes sense. There is a process for converting closed source code to open source code, and it can take time to run through that flow.

miczyg1 commented 1 year ago

Both files are already public: https://github.com/intel/FSP/blob/master/AlderLakeFspBinPkg/IoT/AlderLakeS/Include/MemInfoHob.h https://github.com/intel/FSP/blob/master/AlderLakeFspBinPkg/IoT/AlderLakeS/Include/FirmwareVersionInfoHob.h Closing