search

intel / IA-Hardware-Composer

35 stars 81 forks source link

Limits some monitors' modes due to hardware limitation. #595

Closed yugang closed 5 years ago

yugang commented 5 years ago

Limits some monitors' modes due to hardware limitation.

yugang commented 5 years ago

@js0701 @YuanjunHuang @Shao-Feng , pls check if it can be used to indentify view sonic display.

yugang commented 5 years ago

debug log just as “Monitor name: TD2230 Series, manufacturer: VSC”

yugang commented 5 years ago

Added the original place and modification details of edid.h in comment area.

yugang commented 5 years ago

updated the commit:

  1. removed the third party code.
  2. following the EDID spec, updated the code and struct of display description data of EDID
yugang commented 5 years ago

pls help review and merge it, thank you

js0701 commented 5 years ago

Thanks @yugang

js0701 commented 5 years ago

@yugang I see setMode is limited, but how about getMode? We should avoid expose those invalid modes to AOSP

yugang commented 5 years ago

@js0701 , here we only expose the one prefered mode to mode from modes supportted by i915 connector(as UpdateDisplayState is the only place to init the mode, we just limited here), and all APIs of HWC will only base on "mode_" of the display, whatever getactiveconfig/setactiveconfig/GetDisplayConfigs/UpdateDisplayConfig/SetDrmModeInfo/currentmode/.

js0701 commented 5 years ago

OK

yugang commented 5 years ago

@YuanjunHuang @js0701:

  1. added comments for the CheckLimitedMonitor
  2. defined a string vector HWC_LIMITED_MONITOR_LIST for future appending, e.g. HWC_LIMITED_MONITOR_LIST{"TD2230 Series", "DELL U2414H"}
YuanjunHuang commented 5 years ago

LGTM.

YuanjunHuang commented 5 years ago

please follow https://github.com/intel/IA-Hardware-Composer/wiki/Conformance to fix the coding style conformance issue.

yugang commented 5 years ago

@YuanjunHuang seems it is travis build issue:

` configure: error: Package requirements (libinput >= 0.8.0) were not met:

No package 'libinput' found `

yugang commented 5 years ago

pls hold the merging as i found some diff between android and linux

yugang commented 5 years ago

updated done: resize the display name string instead of using '\0'

yugang commented 5 years ago

added issue tracking on