search

intel / IA-Hardware-Composer

35 stars 81 forks source link

Filter EDIP for prefer and performance config #613

Closed Shao-Feng closed 5 years ago

Shao-Feng commented 5 years ago

Asked by AOSP, only 2 display config should be return to SF one is the preferred config. and the other is optional better performance config.

Change-Id: I966bbdeb819e54b12a5ef37103e593207b95a940 Tests: Work well on Android Q GP Tracked-On: https://jira.devtools.intel.com/browse/OAM-83748 Signed-off-by: Shaofeng Tang shaofeng.tang@intel.com

dyang23 commented 5 years ago

Review +1

jennycao commented 5 years ago

@Shao-Feng with this patch, Do we still need the WA patch Limits some monitors' modes due to hardware limitation. https://github.com/intel/IA-Hardware-Composer/commit/bee374610533f2766de31870026a557bb0fc6357

Shao-Feng commented 5 years ago

In most case, only the prefer display mode will be sent to SF. just in some special case, the performance display mode is different with the preferred one. For the patch, bee3746 it work for the display "TD2230 Series", from the existing mode list of this display, we will also only send the preferred display mode to SF too. but not sure if the display mode list will be changed, and a unsupported EDIP item will be selected as "performance" mode. It should be OK to revert it for current display. but not 100% sure it work in future/with the updated display.

js0701 commented 5 years ago

Please address comments

Shao-Feng commented 5 years ago

Updated for reviewing comments

Shao-Feng commented 5 years ago

Add a commit to revert the Workaround for ViewSonic display