search

intel / IA-Hardware-Composer

35 stars 81 forks source link

Use SurfaceFlinger to do client composite if layers more than 3 #621

Closed dyang23 closed 5 years ago

dyang23 commented 5 years ago

If layers more than 3, layer1 and layer2 set to Device composite type, and other layers set to Client composite type.

Change-Id: I6c32a5d5b3cdd31feb113288fba4afc11842b9b5 Tracked-On: Signed-off-by: Yang, Dong dong.yang@intel.com

js0701 commented 5 years ago

Do we consider video need to be a separated plane, that is not client type here?

js0701 commented 5 years ago

Thanks for this patch I generally agree with it. Beyond the comment, just a few things 1) Explain what is the benefit to return client type say, junky frame rate how much reduce 2) Also you can explain the video layer logic, that is we wish to choose original way when we meet video, the HWC will try to separate planes or use VPP for video 3) Add a switch to choose the old way, it will help us to do debug and analysis

dyang23 commented 5 years ago

If any video layer included, we will keep original logic, that is all the layer will set it as DEVICE type, and how to mapping to plane will handled in present() process.

From: JSLin [mailto:notifications@github.com] Sent: Friday, July 12, 2019 2:38 PM To: intel/IA-Hardware-Composer IA-Hardware-Composer@noreply.github.com Cc: Yang, Dong dong.yang@intel.com; Author author@noreply.github.com Subject: Re: [intel/IA-Hardware-Composer] Use SurfaceFlinger to do client composite if layers more than 3 (#621)

Do we consider video need to be a separated plane, that is not client type here?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/intel/IA-Hardware-Composer/pull/621?email_source=notifications&email_token=AKBVBMG6B6DOFQ76DMGGHKLP7ARD3A5CNFSM4ICCZR2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZY2Y7I#issuecomment-510766205, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKBVBMBU24LMK4MSJRTM7VDP7ARD3ANCNFSM4ICCZR2A.

dyang23 commented 5 years ago

patch update, please review again.

js0701 commented 5 years ago

@dyang23 OK. I will approve. But it just has a not necessary commit? I guess you just need one commit

dyang23 commented 5 years ago

@js0701 Yes, the not used commit already removed, please review again, thanks.