intel / IA-Hardware-Composer

35 stars 81 forks source link

Update ValidateLayers for only 1 plane case #635

Closed Shao-Feng closed 5 years ago

Shao-Feng commented 5 years ago

Only 1 plane is available for HWC on Kvm. Update the logic to 1/ Non-video case and Client is used, all layers are Client. just need to scan out the Client layer 2/ Non-video case and Client is not used, force to compose all layers by GPU 3/ Video case, Force to compose all layers in VPP For video case, still meet surface issue (Fail to allocate surface). Not sure if it is limitation in layer size of VPP. will fix later.

Change-Id: Iabc1fdb0fa8faaca3f49376177eab631d0c571ca Tests: PlaneReservation work for reserve 1 plane on Android Q Tracked-On: https://jira.devtools.intel.com/browse/OAM-84953 Signed-off-by: Shaofeng Tang shaofeng.tang@intel.com

Shao-Feng commented 5 years ago

Add a patch for reading KVM property and loading KVM config 1 issue still remain, deployment script for deploying the new configuration file "hwc_display.kvm.ini" need to be updated in "device/intel/" for all platform

YuanjunHuang commented 5 years ago

what is the behaviour in case: there is video layer + only one plane limitation? It is a known issue right?

Shao-Feng commented 5 years ago

For 1plane and video case, all layers will be composed by VPP. I am still in debugging. it seems it is not the issue in VPP. the current Surface recycling logic have problem to run with only 1 plane if the surface need to be recycled. the surface issue also happen in the case 1Plane + disabling Client layer.

Shao-Feng commented 5 years ago

The deploy script is updated on https://android.intel.com/#/c/679215/1 please help to review, @jennycao

Shao-Feng commented 5 years ago

surface issue is fixed in https://github.com/intel/IA-Hardware-Composer/pull/636

YuanjunHuang commented 5 years ago

LGTM.