search

intel / IA-Hardware-Composer

35 stars 81 forks source link

Revert "support Iris driver" #712

Closed renchenglei closed 3 years ago

renchenglei commented 3 years ago

This reverts commit 9cc7cdc490349db1fa7abd83c85223bcfe5e8cc1.

For CIV, we need keep both i965 driver and iris driver. i965 driver is used for KBL/CML, iris driver is used for TGL, and the two driver is built into one image. We can't check "BOARD_GPU_DRIVERS" flag to disable EXPLICIT_SYNC, as it will cause PnP regression on CML.

Tracked-On: OAM-95784 Signed-off-by: Ren Chenglei chenglei.ren@intel.com

renchenglei commented 3 years ago

Hi @tpalli, mesa is upgrade to 20.2.3 in CIV, do we still need disable EXPLICIT_SYNC for iris?

renchenglei commented 3 years ago

I tried to flash CIV on TGL RVP, Android could boot successfully. @Shao-Feng & @feijiang1 & @YuanjunHuang Could you help take a review of this changes, thanks a lot!

Shao-Feng commented 3 years ago

Does @tpalli agree with this revert?

feijiang1 commented 3 years ago

Does @tpalli agree with this revert?

renchenglei commented 3 years ago

Seems that Tapani is still on a vacation, could we get this merged, and if iris still has issue to support EXPLICIT_SYNC, we can check with device id, instead of BOARD_GPU_DRIVERS flags.

tpalli commented 3 years ago

Seems that Tapani is still on a vacation, could we get this merged, and if iris still has issue to support EXPLICIT_SYNC, we can check with device id, instead of BOARD_GPU_DRIVERS flags.

I'm not on vacation, sorry I just did not spot this until now :) This is OK with me, iris should be working fine (including explicit sync) on Android now.