search

intel / Immintrin-debug

immintrin_dbg.h is an include file, a wrapper around immintrin.h. It implements most of AVX, AVX2, AVX-512 vector intrinsics to enable source level debug of vector code.
BSD 3-Clause "New" or "Revised" License
57 stars 8 forks source link

abs() should be fabs() or fabsf() #7

Open rosbif opened 4 years ago

rosbif commented 4 years ago

All four occurrences of abs() in the function RANGE() should be fabs(). All four occurrences of abs() in the function RANGE32() should be fabsf().

Thank you for your reply to my previous issue. Could you give me a personal email address to contact you, please? You say that you have left Intel so I suppose alexander.komarov@intel.com is no longer current.

izard commented 4 years ago

Thank you very much for the bug reports, I am very embarrassed to write that things. I've committed the fixes. Seems no risk, so I did not run the tests (don't have access to them anyway). My access from this repo should have been removed too, but someone overlooked :) . The guy I transferred it to also left, so not sure who is now in charge at Intel. My email is izard.ak@gmail.com.

rosbif commented 4 years ago

On each line there were two abs() to change. You only modified the second one.

rosbif commented 4 years ago

Maybe Victoria (Zhislina) would be interested in taking over the project. She has contributed and AFAICS she works for Intel but in Russia.

izard commented 4 years ago

She is welcome, I know her pretty well and if she reaches me I can try to recall where she could find the parser/generator/testing scripts that are not here in the repo.