search

intel / IntelSEAPI

IntelSEAPI
201 stars 53 forks source link

Support the Rust intel-seapi library #36

Closed abrown closed 3 years ago

abrown commented 5 years ago

@raphaelcohn used the ittnotify library from this repository for his intel-seapi library and published intel-seapi on crates.io; unfortunately ittnotify required changes in order to compile and run in Rust (see the original changes). @araud, those changes should be discussed and possibly worked on in other PRs before merging. This PR allows us to discuss the changes.

Because of how the original commits were pushed, I had to re-apply the patches using the following steps in my own repository:

curl -L https://github.com/intel/IntelSEAPI/commit/8f20905c07af4a5b510e17cc12f3c7b98e7fe23e.patch | git am
curl -L https://github.com/intel/IntelSEAPI/commit/389d089cc48978a5b3a86b3269951bedbbcf6820.patch | git am
curl -L https://github.com/intel/IntelSEAPI/commit/611e1fab3b0c5a539831d8dda52091cf8ccda528.patch | git am --reject
# then I had to manually change some `static` keywords to `extern` in `ittnotify/src/ittnotify/ittnotify_static.c`
abrown commented 5 years ago

@raphaelcohn as you see it, is there anything to do here other than the USE_MUSL_LIBC changes I mentioned in https://github.com/intel/IntelSEAPI/pull/36#discussion_r304164598? Would that be enough to get intel-seapi building from the latest in this repository?

abrown commented 5 years ago

@raphaelcohn I made the patch to enable MUSL libc support; what command(s) are you running to build this project so that I can test whether this works on my machine?

abrown commented 3 years ago

Closing, since this is a bit old.