search

intel / KVMGT-kernel

Other
41 stars 20 forks source link

fix "error: redefinition of typedef ‘domid_t’" #9

Closed syshack closed 9 years ago

syshack commented 9 years ago

fix "error: redefinition of typedef ‘domid_t’"

full log:

In file included from drivers/xen/vgt/vgt.h:45, from arch/x86/kvm/../../../virt/kvm/vgt_helper.c:12: drivers/xen/vgt/vgt-if.h:236: error: redefinition of typedef ‘domid_t’ include/xen/interface/xen.h:239: note: previous declaration of ‘domid_t’ was here make[2]: * [arch/x86/kvm/../../../virt/kvm/vgt_helper.o] Error 1 make[1]: * [arch/x86/kvm] Error 2 make: *\ [arch/x86] Error 2

l1viathan commented 9 years ago

Hi thanks for this. Curious why I didn't meet this issue :)

Unfortunately I prefer not to pull your fixes, but choose another way instead: splitting the hypervisor-related code from the vgt generic device model, and adopt KVM and Xen independently. IMHO the latter would be a better choice, and more acceptable from the perspective of upstream :)

syshack commented 9 years ago

Okay. Thank you for your advice, I wil try it.