intel / NMPRK

3 stars 10 forks source link

Calls die without returning a response. #1

Closed jrmassoni closed 12 years ago

jrmassoni commented 12 years ago

Calls should return a response with an error code if they fail, no error code is return and the commands sometimes just die. This doesn't allow the programmer to try to recover or exit gracefully. An example of this is the getPolicy command sometimes dies and displays the message "Failed", not letting me know why it failed, or allowing me to retry the command, or allowing me to exit my program gracefully.

jrmassoni commented 12 years ago

This was partly a problem of some debug code existing that needed to be removed (oops). The other issues related to this is that in some cases the code was just never finished to add in the messages. Or the code actually modifies the return code from what IPMI returns to a different value, and that the code is returned as part of a message. There needs to be a more unified way to return errors to the parent application so it can know what is going on and can take action on it.

yilongx commented 12 years ago

when can we get the latest version for retest? shall we get the source from this github or release tar ball?

jrmassoni commented 12 years ago

Updated the code to return IPMI values for calls. Now in the test code you can test for the IPMI code to determine what the error was and then decide on that what actions to take.

jrmassoni commented 12 years ago

Actually there are still many cases in reading the SEL, SDR and FRU where it returns with just a false and no error. What am I suppose to do and why did it die? These should return some type of error code indicating why they died. Reopening this defect.

jrmassoni commented 12 years ago

The error coding has greatly been improved in the coming Sept 2012 release. We are sure there are still cases where an error code and message are not returned, but it should be a lot less. Will keep this defect open until we have confidence we have found nearly all cases, and then handle them on a case by case basis.

jrmassoni commented 12 years ago

This have been greatly improved for the September release. Any future bugs in this area will be handled on a case by case basis.