search

intel / PerfSpect

System performance analysis and characterization tool
BSD 3-Clause "New" or "Revised" License
339 stars 31 forks source link

Dependency simpleval needed #5

Closed jpf18 closed 2 years ago

jpf18 commented 2 years ago

PerfSpect imports module simpleeval. This is not available in a fresh installation of Python (at least was not in mine), and needs a separate install. pip install simpleeval I recommend adding the installation of module simpleeval to the build of PerfSpect

karanrk commented 2 years ago

@jpf18 - yes, we do use simpleeval module and is part of the requirements.txt. However, the build.sh should take care of the all the prerequisites required for the build including simpleeval. I've had issues with pyinstaller and simpleeval not complementing each other, hence we decided to use simpleeval source for PerfSpect's build process.

jpf18 commented 2 years ago

Hi karanrk, thank you for the clarification. Net net, after I running build.sh, simpleeval was not available for import in perf-collect.py.

karanrk commented 2 years ago

That's expected as all the pre-requisites are installed in the docker container used for the build. Binaries are executable but not the python files (perf-collect.py and perf-postprocess.py). You could also use pre-built binaries from tagged release