intel / PerfSpect

System performance characterization tool based on linux perf
https://intel.github.io/PerfSpect/
BSD 3-Clause "New" or "Revised" License
333 stars 30 forks source link

Builder removed? #63

Closed vsoch closed 9 months ago

vsoch commented 9 months ago

Hi! I'm looking to try this in Kubernetes (with the Daemonset) and noticed that your previous builder https://github.com/intel/PerfSpect/tree/ba15bcf7a28099c0cf38f6687f42c680dabbc69c/builder directory was removed. Was this intentional - is this a good starting base for what is referenced as the perrspect image here:

https://github.com/intel/PerfSpect/blob/6b548dd5863b6fc9c15fb379aecb4026040220d0/docs/daemonset.yml#L23

I want to double check it wasn't removed because it doesn't work. :P

Thanks!

hilldani commented 9 months ago

That builder dockerfile was from a legacy build system so it installs a lot of things you don't need. PerfSpect works fine in any base docker image (debian, ubuntu, AL2 etc.) as long as linux perf is installed and the host k8s cluster instance has PMU exposed (we have validated it in EKS cluster of metal instances but it will also work in full socket VM's or m7i/c7i's).

vsoch commented 9 months ago

Excellent! Do you have an example Dockerfile for Kubernetes or should I start from the one referenced there and figure it out?

I think my team has also some experience exposing PMU in EKS - do you know if this is possible in GKE?

vsoch commented 9 months ago

I'm asking if this is possible in GKE too. https://twitter.com/vsoch/status/1734329816474615890

hilldani commented 9 months ago

Do you have an example Dockerfile for Kubernetes

  1. pick you favorite base image
  2. install linux perf
    sudo apt install linux-perf                # debian
    sudo yum install perf                      # centos AL2 etc.
    sudo apt install -y linux-tools-`uname -r` # ubuntu

    Perfspect should work fine. Let me know if you encounter any other difficulties

do you know if this is possible in GKE

I would ask your gcp account rep if/how to enable

vsoch commented 9 months ago

nice! Thank you - will build this and ask about GKE tomorrow. I'm good to close this issue, thanks for the help!