intel / SGX-TDX-DCAP-QuoteVerificationLibrary

Other
6 stars 1 forks source link

Build warning C4244 on Windows #2

Open dashuaic opened 9 months ago

dashuaic commented 9 months ago

There is a build warning for this line https://github.com/intel/SGX-TDX-DCAP-QuoteVerificationLibrary/blob/16b7291a7a86e486fdfcf1dfb4be885c0cc00b4e/Src/AttestationLibrary/src/Verifiers/QuoteVerifier.cpp#L482C3-L487C16

The toupper return type is int when transform expect a char.

The warning message as below. message : see reference to function template instantiation '_InputIterator std::find_if<std::wrap_iter<const intel::sgx::dcap::parser::json::TdxModuleIdentity *>,getTdxModuleTcblevel::>(_InputIterator,_InputIterator,_Predicate)' being compiled 1> with 1> [ 1> _InputIterator=std::wrap_iter<const intel::sgx::dcap::parser::json::TdxModuleIdentity *>, 1> _Predicate=getTdxModuleTcblevel:: 1> ] 1>C:\Program Files (x86)\Intel\IntelSGXSDK\include\libc++\algorithm(1968,25): warning C4244: '=': conversion from 'int' to '_Tp', possible loss of data 1> with 1> [ 1> _Tp=char 1> ]