search

intel / ad-rss-lib

Library implementing the Responsibility Sensitive Safety model (RSS) for Autonomous Vehicles
https://intel.github.io/ad-rss-lib/
GNU Lesser General Public License v2.1
336 stars 138 forks source link

Use standard from CMake #101

Closed daedric closed 3 years ago

daedric commented 3 years ago

Hi folks, Given that the C++ standard is hardcoded to 14: https://github.com/intel/ad-rss-lib/blob/ea228498a01971ef3cba7af29cf8483ed429ffad/ad_rss_map_integration/python/CMakeLists.txt#L14

Wouldn't it be worth to generate the python_wrapper_helper.py to actually forward it to gccxml https://github.com/intel/ad-rss-lib/blob/ea228498a01971ef3cba7af29cf8483ed429ffad/cmake/python/python_wrapper_helper.py#L82 ?

If there is no reason for it to be hardcoded this way, I'd gladly make a PR, Cheers,

berndgassmann commented 3 years ago

Hi, There is no explicit reason for this; it's just as it has grown I'd say ;-) Making it more flexible would be appreciated, yes. So if you have a simple solution, great! Waiting for your PR,

Thanks very much