Closed mdrwiega closed 2 years ago
Sorry, I forgot to update the workflows configuration. And thanks for pointing this out.
I have just switched the mode in actions/checkout
to recursive
(apart from code_format_check.yml
).
Thanks again for updating the PR. I have just triggered PR #118 to get rid of the remaining problem in the above runs as the PROJ was removed in map already at the latest revision.
Merging #117 (378e92d) into master (afa7342) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #117 +/- ##
=======================================
Coverage 82.00% 82.00%
=======================================
Files 268 268
Lines 34833 34833
Branches 6404 6404
=======================================
Hits 28566 28566
Misses 805 805
Partials 5462 5462
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update afa7342...378e92d. Read the comment docs.
Thanks again for proving the input
Checklist:
master
branch and tested with latest changesDescription
The
spdlog
is added toad-rss-lib
as dependency and it's added tocarla_simulator/map
that is also the dependency ofad-rss-lib
. Because of that, it's not possible to update submodules recursively.In this PR, the
spdlog
dependency is removed fromad-rss-lib
, so only one version remains incarla_simulator/map
. It allows adding thead-rss-lib
to other packages (especially ROS2 packages) as dependency and updating dependencies with --recursive option.Fixes #116
Where has this been tested?
Possible Drawbacks
This change is