search

intel / appframework

The definitive HTML5 mobile javascript framework
http://app-framework-software.intel.com/
MIT License
2.43k stars 882 forks source link

Error with Maps and slideMenu #623

Closed pabloalcaraz closed 10 years ago

pabloalcaraz commented 10 years ago

I have a slideMenu in a panel with a Map (OSM with Leaflet) when I try to drag the map on desktop (Chrome in Mac) browser it doesn't work and the console shows the next error: Uncaught TypeError: Object # has no method 'trim'.

In Android Chrome not work but yes in stock browser and safari on ipad.

imaffett commented 10 years ago

Hi @pabloalcaraz

Can you post a demo somewhere that I can debug?

pabloalcaraz commented 10 years ago

Yes, you can check it in foguerapp.com/pruebas

imaffett commented 10 years ago

Can you do a test for me? Change line 936 to

this[i].className = this[i].className.trim&&this[i].className.trim();
pabloalcaraz commented 10 years ago

Yes of course, but what file?

imaffett commented 10 years ago

appframework.js - if you fire up Chrome Development Tools, it shows you where the error is

pabloalcaraz commented 10 years ago

Changed

imaffett commented 10 years ago

The error is gone, but there are 403 issues from leaflet. Is it working for you?

pabloalcaraz commented 10 years ago

Yes I know, it's cloudmade tiles, I have to change the source of them. Thanks!

imaffett commented 10 years ago

@pabloalcaraz - just to confirm, this fixes your issue? If so, I will push the fix into master.

pabloalcaraz commented 10 years ago

No, I changed the tiles and there are no errors but I can't drag in chrome desktop.

On Android Crhome works fine the map, but I can't do tap, doesn't work.

imaffett commented 10 years ago

"I can't do tap, doesn't work". I'm not sure what that means. Are you using the latest App Framework UI?

As to desktop, we only provide minimal support for development/testing. The issue is due to a collision with leaflet - we will not fix this.

pabloalcaraz commented 10 years ago

Sorry, I expressed myself badly, maybe there are another Issue, I thought of the same thing happening, but seems not.

When I open the url from Android Chrome browser I can't do tap or "click" nowhere, only works the slide menu. In Android stock browser and Safari on iOs the app works perfectly, but not in chrome.

In iOs Chrome neither, the app works but it's very slow, I tap, and after 2-3 seconds change the page.

I disable leaflet and there are no errors in console (except inside the calendar 'has no method sort') but no matter for now.

imaffett commented 10 years ago

Have you upgraded to the latest? There was a fix for Chrome

https://github.com/01org/appframework/commit/879e3cab78cf01990bf7138831b735bbf97a8eb0

pabloalcaraz commented 10 years ago

Ok, with last appframework.ui.js works perfectly in Chrome, Thanks!