intel / appframework

The definitive HTML5 mobile javascript framework
http://app-framework-software.intel.com/
MIT License
2.43k stars 881 forks source link

on iPhone, side menu button does not respond to first tap, needs a second tab #761

Closed glen2023 closed 9 years ago

glen2023 commented 10 years ago

on 2.1.0, when I activate the side menu using af.slidemenu.js plugin, none of the menu buttons are reacting to the first touch (tap), the second tab works. This is only the case when the menu is activated by swiping. if I activate the menu by taping the menu button, the buttons work the first time.

imaffett commented 10 years ago

Please see the readme for reporting bugs. You need to provide a demo, otherwise we can't help.

glen2023 commented 10 years ago

I installed the appframework.2.1.0.zip, and installed in to my server without any modification.

I viewed the left side menu by swiping right, after the side menu showed, I tap to scroller (or any) button. The first touch does not respond, but second tap shows the scroller.

If I open the side menu using the menu button on upper left, side menu buttons works as expected on the first tap.

Please open my unmodified installation at http://ocal.com/js/x/af/index.html in iphone and test it.

imaffett commented 10 years ago

which button or scroller? Is it the main content area or the menu?

Which device? which os?

glen2023 commented 10 years ago

Sorry about not being clear. Problem is not the scroller itself; if the "Left Menu" is enabled by using a right swipe, any button on the "Left Menu" fails the same way; the first tap on any of the menu buttons are ignored, the second tap works as expected. If the left menu is enabled by using the top left image button, everything works normally.

It fails on iphone 4s, and 4s. it works normally on Nexus android.

imaffett commented 10 years ago

This should be resolved now.

glen2023 commented 9 years ago

I narrowed down the problem. on version 2.1.0 on iphone5, if the buttun/link count on the left side menu is larger then it would fit to the screen (holding the phone horizontal or vertical), the first ever tab on these left side menu items are ignored, but the second tab on to the same button works as expected.

To demostrate: template-SideMenuApp-both.html works because there is only three item on the side menu.

The kitchen sink demo app in the demonstration has this problem. It takes to taps to activate the items on the leff side menu.

I hope this issue is solve soon.

Imaffet, could you please open the issue, it is not solved yet.

Thank you.

imaffett commented 9 years ago

@glen2023 - I fixed this yesterday. "template-SideMenuApp-both" is from another repo and has an old version of App Framework

This commit has the fix in it - https://github.com/01org/appframework/commit/68dfc1ae78973bb59d22472c671c972b5d89ffcd#diff-f1186894ac91e6834e32cda3e1799effR3631

This was preventing the click from being dispatched. You can verify by getting on a Mac, using iOS remote debugging and stepping through. When the side menu was activated by swiping, it would fall through to that case and NOT fire the click event in ontouchend.

imaffett commented 9 years ago

FYI - test against the kitchen sink using the latest code. it works