search

intel / asynch_mode_nginx

Other
210 stars 61 forks source link

修复keepalive模式下，large header的处理错误 #23

Closed jiangzhuti closed 5 years ago

jiangzhuti commented 5 years ago

此处应该是遗漏了hc->nbusy=0

daweiq commented 5 years ago

非常感谢你的patch，请问你是如何触发keep alive下large header错误的？

jiangzhuti commented 5 years ago

非常感谢你的patch，请问你是如何触发keep alive下large header错误的？

keepalive模式，每次请求附带长header，到第五次请求返回400错误码

daweiq commented 5 years ago

好的，我们会先验证一下patch，然后再进一步处理。

jiangzhuti commented 5 years ago

好的，我们会先验证一下patch，然后再进一步处理。

用的是默认配置 http://nginx.org/en/docs/http/ngx_http_core_module.html#client_header_buffer_size

zhangp8x commented 5 years ago

@jiangzhuti: Sincere apologies for very late reply to this pull request. We intend to merge this pull request which will go through the internal process and should be available in the next release. But before that the commit message in the pull request does not contain "Signed-off-by:" in it adhering to license and Developer Certification of Origin. Could you please update the pull request commit message with "Signed-off-by:" in the following format Signed-off-by: Name

Note: You are required to use your real name in the sign-off message.

zhangp8x commented 5 years ago

@jiangzhuti Do not forget to provide your email at the same time.

jiangzhuti commented 5 years ago

@zhangp8x commit message updated, is this okay?

daweiq commented 5 years ago

@jiangzhuti The changes are done and merged in the internal branch. It should be available in Github with the next release. Thanks for your contribution!

daweiq commented 5 years ago

Patch included in v0.3.9 release, thank you for contribution!