search

intel / asynch_mode_nginx

Other
210 stars 60 forks source link

fix: when using ssl_enabled to determine whether NGX_SSL is defined #42

Closed rainingmaster closed 3 years ago

zhangp8x commented 3 years ago

@rainingmaster Thank you for your MR, the sign-off-by is required. Your contribution will be discussed and will give you feedback asap.

The commit message in the pull request does not contain "Signed-off-by:" in it adhering to license and Developer Certification of Origin. Could you please update the pull request commit message with "Signed-off-by:" in the following format Signed-off-by: Name Note: You are required to use your real name in the sign-off message.

rainingmaster commented 3 years ago

@zhangp8x

Hi, Thanks for reply, I have finish the sign-off

zhangp8x commented 3 years ago

@rainingmaster

What issue does this patch fixed? Could you please add more information?

rainingmaster commented 3 years ago

@zhangp8x

Hi, sorry for my delay. When I run ./configure && make under this repo(in fact I forgot add --with-stream_ssl_module or --with-http_ssl_module), we will get an error: error: no member named 'ssl_enabled' in 'struct ngx_connection_s'.

As I investigate, this repo should support build without NGX_SSL, such as this change, so I think we should keep the code style always.

zhangp8x commented 3 years ago

@rainingmaster

Your PR would be released in next release. Thank you for your support.