search

intel / buxton

8 stars 9 forks source link

managing timeout #139

Open jobol opened 9 years ago

jobol commented 9 years ago

The current implementation doesn't allow clients to change the timeout.

This has a weird effect when debugging. For example, an option could be add to buxtonctl to change the timeout (to the infinite value 0 for example). Also a client could expect answer in less than 5 seconds.

Any of this changes could be done by managing the poll by the client so it isn't a priority. However, having an option or a verb to set the timeout could be great.

Do you agreed?

ikeydoherty commented 9 years ago

I'm unsure what benefit this has. We only have a timeout to ensure we kill clients that have dropped. Clients can't really be trusted to tell us that they have great connections so don't kill them :) Also an infinite timeout offers no benefit and would lead to DoS situations, with clients slowly taxing the resources by opening infinite timeout connections and never fully completing requests. (i.e. slowloris)

bryteise commented 9 years ago

I agree with @ikeydoherty for this. Though it does make debugging a little trickier. Perhaps we could add a configure.ac option for changing the timeout.