search

intel / cc-oci-runtime

OCI (Open Containers Initiative) compatible runtime for Intel® Architecture
GNU General Public License v2.0
416 stars 59 forks source link

automate checking of Signed-off-by attestations #113

Closed grahamwhaley closed 8 years ago

grahamwhaley commented 8 years ago

Our policy is that all commits must have a developer attestation 'Signed-off-by' tag in them. Currently this is a manually checked process, and one day we will miss one no doubt. If possible we should try and automate checking for the tags. It is not clear if we can do this in the 'github status checks' or if we will do it in the Travis checks. This might get handled by #110 , whereby the 'checkpatch.pl' will pick up the lack of Signed-off-by.

jodh-intel commented 8 years ago

This would also be handled by https://github.com/jodh-intel/cc-oci-runtime/tree/add-pullapprove-support since in that branch, .pullapprove.yml specifies:

signed_off_by:
  required: true

See http://docs.pullapprove.com/yaml/signed_off_by/

jodh-intel commented 8 years ago

We've now enabled pullapprove (see https://github.com/01org/cc-oci-runtime/wiki/Release-Process) which is now checking Signed-off-by.