search

intel / cc-oci-runtime

OCI (Open Containers Initiative) compatible runtime for Intel® Architecture
GNU General Public License v2.0
417 stars 59 forks source link

Automate release checklist tasks #851

Open jodh-intel opened 7 years ago

jodh-intel commented 7 years ago

Ideally, we'd have a script that could run the steps listed on the wiki here:

We're getting close to being able to automatically handle the OBS aspects (#672), which then leaves us with the question of whether we can automate the generation of the release notes.

dlespiau commented 7 years ago

We can at least generate the list of fixed bugs by:

  1. parsing git log and looking for Fixes: tags.
  2. query the list of issues fixed between 2 dates. The latter is more exhaustive if we forget to put Fixes: tags and will have false positives (issues we have closed but not fixed).

I'd vote for 1. and have everyone reminded about those Fixes: tags.

jodh-intel commented 7 years ago

Agreed. I think as reviewers we should consider start requiring atleast one Fixes # in the commit messages.

jodh-intel commented 7 years ago

@grahamwhaley, @sameo - what do you think? Should we require every PR to be coupled with an issue along with a Fixes # comment?

grahamwhaley commented 7 years ago

My thought was that, sure, auto-grabbing and filtering for 'fixes' and similar is good and fine - but, I also expect something will always slip through the net. I expect a final stage in the release process will always have to be a visual sanity check and xref to ensure the auto generated notes container all the right things (and none of the 'wrong things'). Automation good - but I don't think we can trust it 100% to generate the final notes without human review.

jodh-intel commented 7 years ago

absolutely +1.

devimc commented 7 years ago 
- but I don't think we can trust it 100% to generate the final notes without human review.

agree, we can't trust

sameo commented 7 years ago

As we enter into a more stable phase for COR, we do want PRs to be coupled with at least one issue. So I agree we should enforce the Fixes tag in PRs. We could even have pullapprove verify that for us.

jodh-intel commented 7 years ago

I've raised #856 to update our contribution guidelines. See the same issue for details of pullapprove.