search

intel / ccloudvm

Configurable Cloud VM is a small command line tool for automatically creating development and demo environments for complex projects. The tool sets up these development environments inside a virtual machine which it automatically creates on the user’s host computer. This avoids polluting the user’s host machine with components from the chosen development environment and provides a clean, predictable and repeatable environment in which this development environment can run.
Apache License 2.0
32 stars 19 forks source link

Update the clearcontainers-3.x workload #82

Closed markdryan closed 6 years ago

markdryan commented 6 years ago

This commit makes a number of changes to the clearcontainers-3.x workload.

  1. The workload now derives from docker-xenial, which allows us to remove a lot of code. The workload also benefits from the fact that docker-xenial installs the latest version of docker-ce and sets up proxies correctly inside the containers as well as outside.
  2. Made the installation instructions for cc3.x match the instructions on the CC wiki.
  3. Update the version of Go used.
  4. Removed CRI-O and K8S. The CRI-O installation didn't work anyway.
markdryan commented 6 years ago

@egernst, @mcastelino, @devimc Here's the proposed update to the clear-containers3-x workload. Let me know if you think this will cause any issues. It doesn't seem to be used much at the moment, so hopefully it won't.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 68.226% when pulling 8d551e0a5e28d27d7b1f2faa49ff649a10909531 on markdryan:fix-cc-3.0 into 8d9557fe9f7559eebef1ed02814f8eddd0ca6262 on intel:master.

devimc commented 6 years ago

@markdryan did you test CC 3.0 with golang 1.10 ? did you run all the tests ?

markdryan commented 6 years ago

@devimc It turns out go vet 1.10 reports errors on the cc code. So I've downgraded the workload to use 1.9.2. Thanks for catching this.

devimc commented 6 years ago

lgtm

rbradford commented 6 years ago

Commands in the MOTD don't seem to be quite correct:

rob@alarmed-arthur:~$ go get -d github.com/clearcontainers/runtime... 
package github.com/clearcontainers/runtime...: cannot expand ... in "github.com/clearcontainers/runtime..."
rbradford commented 6 years ago 
rob@alarmed-arthur:~/go/src/github.com/clearcontainers/runtime$ sudo -E PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin make install-cc-system 
make: go: Command not found
Makefile:38: arch/-options.mk: No such file or directory
make: *** No rule to make target 'arch/-options.mk'.  Stop.

The directory where go is installed also needs to be in PATH

rbradford commented 6 years ago

Might also be worth doing s/cor/cc-runtime/ in the docker systemd file as that seems to be what upstream does.