intel / ccloudvm

Configurable Cloud VM is a small command line tool for automatically creating development and demo environments for complex projects. The tool sets up these development environments inside a virtual machine which it automatically creates on the user’s host computer. This avoids polluting the user’s host machine with components from the chosen development environment and provides a clean, predictable and repeatable environment in which this development environment can run.
Apache License 2.0
32 stars 19 forks source link

Make the name generator more random #85

Closed markdryan closed 6 years ago

markdryan commented 6 years ago

The random shuffle algorithm used by the name generator was buggy. It swapped N pairs of randomly selected names, where N is the total number of names. What it should have been doing was swapping each name with a randomly chosen name. This makes it much more likely that each name will be moved from its original position in the slice of possible names. There should be fewer alarmed-agravains from now on.

Signed-off-by: Mark Ryan mark.d.ryan@intel.com

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.01%) to 68.241% when pulling e2a455c2fcdd00324ddd494ff4d1bff4b989005d on markdryan:fix-shuffle into 580e0afd42ae1bb67f2bd00d597dd7064bf80c6f on intel:master.