intel / ccloudvm

Configurable Cloud VM is a small command line tool for automatically creating development and demo environments for complex projects. The tool sets up these development environments inside a virtual machine which it automatically creates on the user’s host computer. This avoids polluting the user’s host machine with components from the chosen development environment and provides a clean, predictable and repeatable environment in which this development environment can run.
Apache License 2.0
32 stars 19 forks source link

Fix workload search #90

Closed markdryan closed 6 years ago

markdryan commented 6 years ago

ccloudvm was unable to find the workload directory if the directory resided in a GOPATH that was not the default. The reason was that the search is performed using the environment variables of the service and not that of the client. Although the client's GOPATH is passed into the service it was not being used when searching for workloads. This has now been fixed:

Fixes: https://github.com/intel/ccloudvm/issues/87

Signed-off-by: Mark Ryan mark.d.ryan@intel.com

ganeshmaharaj commented 6 years ago

@markdryan does the semaphore failure want us to explicitly set GOPATH? i thought it would work fine with the default. will test it out locally later today.

markdryan commented 6 years ago

Ah, I hadn't noticed that this had failed. Let me take a look to see why.

markdryan commented 6 years ago

@ganeshmaharaj All fixed now. One of the tests was not setting the GoPath correctly, or at all.