intel / cloud-native-ai-pipeline

AI cloud native pipeline for confidential and sustainable computing
https://intel.github.io/cloud-native-ai-pipeline/
Apache License 2.0
37 stars 15 forks source link

Correct docker build PATH to build context location. #124

Closed pingzhaozz closed 1 year ago

pingzhaozz commented 1 year ago

Fix the problem that can't find correct context during docker build.

leyao-daily commented 1 year ago

Thanks for you contirbution. Can you explain more about your changes, what issues do you meet when building the image.

pingzhaozz commented 1 year ago

The PATH parameter is the build context location, which mostly use same Dockerfile location. So that if the Dockerfile use patch or other files that docker build could find them. Otherwise build will failure can't find the context file. So far the containers only have Dockerfile which doesn't have issue. But when you add new containers the problem will happen.

leyao-daily commented 1 year ago

We use the root as the file context, and all the execution in dockerfile should be considered as a relative path based on the root path.

pingzhaozz commented 1 year ago

close this PR as it use top directory for context