search

intel / collision-avoidance-library

A framework for testing and benchmarking collision avoidance strategies
Apache License 2.0
81 stars 39 forks source link

coav-sim.sh: Fix PX4 + jmavsim exit process #116

Closed mbelluzzo closed 7 years ago

mbelluzzo commented 7 years ago

Set a new session for px4+jmavsim processes and uses the process group ID to properly kill the related child process.

Signed-off-by: Murilo Belluzzo murilo.belluzzo@intel.com

mbelluzzo commented 7 years ago

That was I discovered when I was looking to see what Ctrl+c was doing of different than kill -INT. The nitpick was that when issued by testbed, testbed itself end up being the leader, so to kill everything we would have to kill it as well, thus the new session.

On Mon, Mar 20, 2017, 18:49 Rodrigo Chiossi notifications@github.com wrote:

@rchiossi approved this pull request.

Hmm, nice one. I didn't know that would work. But does killing the group leader kills everything? Sometimes I got a leftover jmavsim even when closing its parent terminal. If so, LGTM.

— You are receiving this because you authored the thread.

Reply to this email directly, view it on GitHub https://github.com/01org/collision-avoidance-library/pull/116#pullrequestreview-28007631, or mute the thread https://github.com/notifications/unsubscribe-auth/ABgsZRmEAkSNrOXCUcIj4K4Plhfy_IvKks5rnyy2gaJpZM4MjMEq .