search

intel / collision-avoidance-library

A framework for testing and benchmarking collision avoidance strategies
Apache License 2.0
81 stars 39 forks source link

Make VDebug Great Again #125

Closed rchiossi closed 7 years ago

rchiossi commented 7 years ago

Note: This is almost a complete rewrite of the code, ignore the diff.

VDebug is a great tool for debugging detection algorithms, but it was not updated along with the rest of the code. This is a complete rework of the code. Some of the features of this new version:

Signed-off-by: Rodrigo Chiossi rodrigo.chiossi@intel.com

mbelluzzo commented 7 years ago

That is awesome, code wise is looking good, but I think that there is something to be fixed about the obstacle positions on vdebug. I did a test here and vdebug was showing obstacle as being detected on different positions of what the visualization code is showing:

screenshot from 2017-05-18 17-36-00

screenshot from 2017-05-18 17-37-28

rchiossi commented 7 years ago

hmm, thats curious... I was testing with a real realsense in my room and the detection seemed correct. I'll test with your branch then.

rchiossi commented 7 years ago

btw, did you disable the grid or is it also a bug?

mbelluzzo commented 7 years ago

I didn't change anything, once I move the camera, it disappears. Probably something on the graphic libraries

On Thu, May 18, 2017, 17:51 Rodrigo Chiossi notifications@github.com wrote:

btw, did you disable the grid or is it also a bug?

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/01org/collision-avoidance-library/pull/125#issuecomment-302579507, or mute the thread https://github.com/notifications/unsubscribe-auth/ABgsZXipINrK4-sQ6drphzx6MDE_Dwucks5r7OeIgaJpZM4NergQ .

mbelluzzo commented 7 years ago

Lets go with the coav-control version. Closing this