search

intel / collision-avoidance-library

A framework for testing and benchmarking collision avoidance strategies
Apache License 2.0
81 stars 39 forks source link

Add missing include directories to RealSenseCamera #39

Closed rchiossi closed 7 years ago

rchiossi commented 7 years ago

If RealSense headers were out of the default include path, the build would fail. This patch adds the missing include parameters to cmake.

mbelluzzo commented 7 years ago

Same result:

 64%] Building CXX object samples/CMakeFiles/coav_gcs.dir/coav_gcs.cc.o
cd /home/murilo/projects/vision/coav-intel/collision-avoidance-library/build/samples && /usr/bin/c++   -DLIBBULLET_VERSION=2.85 -DLIBBULLET_VERSION_GT_282 -DUSING_REALSENSE -I/home/murilo/projects/vision/coav-intel/collision-avoidance-library -I/usr/local/include -I/usr/local/include/gazebo-8 -I/usr/include/bullet -I/usr/local/include/sdformat-4.1 -I/usr/local/include/ignition/math2 -I/usr/include/OGRE -I/usr/include/OGRE/Terrain -I/usr/include/OGRE/Paging -I/home/murilo/projects/vision/coav-intel/collision-avoidance-library/interfaces -I/home/murilo/projects/vision/coav-intel/collision-avoidance-library/modules/mavlink_vehicles/src -I/home/murilo/root/include/mavlink/v1.0/autoquad  -fstack-protector-all -fPIE -fPIC -O2 -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -std=c++11  -Wall   -std=gnu++11 -o CMakeFiles/coav_gcs.dir/coav_gcs.cc.o -c /home/murilo/projects/vision/coav-intel/collision-avoidance-library/samples/coav_gcs.cc
In file included from /home/murilo/projects/vision/coav-intel/collision-avoidance-library/samples/coav_gcs.cc:35:0:
/home/murilo/projects/vision/coav-intel/collision-avoidance-library/sensors/RealSenseCamera.hh:18:31: fatal error: librealsense/rs.hpp: No such file or directory
 #include <librealsense/rs.hpp>
                               ^
rchiossi commented 7 years ago

if you add the following lines at the end of sensors/CMakeLists.txt does it prints the correct include folders when running cmake ?

get_property(dirs TARGET sensors PROPERTY INCLUDE_DIRECTORIES)
foreach(dir in ${dirs})
    message(${dir})
endforeach()

It's working in my case, but my guess is that the list is overwritten in some other part of the build.

rchiossi commented 7 years ago

@mbelluzzo, I just noticed that this is not the same error. The previous one was when compiling RealSenseCamera. This one is when compiling coav_gcs.

Change PRIVATE to PUBLIC in target_include_directories() in sensors/CMakeLists.txt. It should do the trick.

rchiossi commented 7 years ago

Better yet, don't change anything. I'm gonna double check all the includes and send a new PR on Monday. ;)

mbelluzzo commented 7 years ago

Roger that.

On Fri, Nov 4, 2016 at 5:07 PM, Rodrigo Chiossi notifications@github.com wrote:

Better yet, don't change anything. I'm gonna double check all the includes and send a new PR on Monday. ;)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/01org/collision-avoidance-library/pull/39#issuecomment-258576241, or mute the thread https://github.com/notifications/unsubscribe-auth/ABgsZU5q3ki-kxgkd2FgYXVghqKaAZXdks5q68jHgaJpZM4KqDCl .