search

intel / collision-avoidance-library

A framework for testing and benchmarking collision avoidance strategies
Apache License 2.0
81 stars 39 forks source link

Samples gazeboless #44

Closed mbelluzzo closed 7 years ago

mbelluzzo commented 7 years ago

Draft Fix #43. More robust, tested on my machine, drone tests tomorrow.

mbelluzzo commented 7 years ago

Hhhmm that's why compilation succeed so easily hehehehe I was so worried to check the simbols with ldd and endup f***ing everything. I will fix that. I will fix that

mbelluzzo commented 7 years ago

"Sending patches Barba's style?! ;)" but is like 1/1000 of what he does hehehe I only corrected typos/empty space, he pushes new features and refactored code etc

mbelluzzo commented 7 years ago

V2, @rchiossi take a look plz

mbelluzzo commented 7 years ago

Because it was provided by gazebo flags/dependencies

On Wed, Nov 30, 2016, 07:34 Rodrigo Chiossi notifications@github.com wrote:

@rchiossi commented on this pull request.

In vehicles/CMakeLists.txt https://github.com/01org/collision-avoidance-library/pull/44:

@@ -9,4 +9,4 @@ if (${WITH_GAZEBO}) endif()

add_library(vehicles ${SOURCES}) -target_link_libraries(vehicles ${LIBRARIES}) +target_link_libraries(vehicles PRIVATE ${LIBRARIES} PUBLIC "-pthread")

Hmm, that's weird... if this was required before, why we didn't get any errors?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/01org/collision-avoidance-library/pull/44, or mute the thread https://github.com/notifications/unsubscribe-auth/ABgsZb4cGQMHXOBuxgJUmM9G27tJPQuDks5rDZeBgaJpZM4K-gU4 .

rchiossi commented 7 years ago

Also, it's a good idea to create a new PR when you send a new version of your patchset so that comments don't get mixed up.

mbelluzzo commented 7 years ago

Merged the first 4 patches. I will keep the simple gcs in the pocket for now.