search

intel / collision-avoidance-library

A framework for testing and benchmarking collision avoidance strategies
Apache License 2.0
81 stars 39 forks source link

Get rid "gcs" terminology + mv tests to the correct folder. #74

Closed mbelluzzo closed 7 years ago

mbelluzzo commented 7 years ago

Testbed commit -> I just did that to remove coav_gcs without break it while we dont have coav-sim merged because we will have ppl looking at the project in between. So is temporary but not pointless. So I'm going to merge the commits except the Move test that needs to be re-done.

rchiossi commented 7 years ago

Yeah, i figured as much. That's fine, there is no harm in merging it.

mbelluzzo commented 7 years ago

polarhist_test.cc should be renamed to polarhist_sample.cc and keept at the samples folder. It is more of a sample on how to use polarhist than a polar hist test itself.

In this case you are totally write, its a small app that shows the usage of a given detector and has a simple output used for demonstration.

Commit "Move test apps out of 'samples' folder" is all wrong. test.cc should be renamed to vdebug and moved into the tools directory. The idea is to keep tests that can be automated in tests/ folder, and thats not the case with polarhist_test.

But here is where I have to disagree, test.cc is a horrible sample, it actually has little to no value as a sample at all. It really isn't an automated test but its a testing tool more than a sample. Its only purpose is to help one "test" if the simulated camera input is working. Maybe it should be coav-control's neighbor under tools?

rchiossi commented 7 years ago

well, that's what I wrote there... "test.cc should be renamed to vdebug and moved into the tools directory"

mbelluzzo commented 7 years ago

I'm getting old fast :-(