Remnants of XeHP SDV in the code base - Githubissues

intel / compute-runtime

Intel® Graphics Compute Runtime for oneAPI Level Zero and OpenCL™ Driver

MIT License

1.1k stars 229 forks source link

Remnants of XeHP SDV in the code base #678

Closed al42and closed 9 months ago

al42and commented 9 months ago

There are a few references to SUPPORT_XE_HP_SDV and xeHpSdvDeviceIds left in the codebase despite the majority of the related functionality removed in 260003caa87a06b36fa1097a5da4ae1649986530, faa8907344e5ff4e8076570ee44dbd56cbf6030d, cf73ab0df351903808be210fa8f708bbf79bd955.

https://github.com/intel/compute-runtime/blob/eebf2bbd26c1684f40142a08d9295a5cbb74d706/shared/source/dll/devices/product_config_base.inl#L42 is the only mention of xeHpSdvDeviceIds devices left.
SUPPORT_XE_HP_SDV is not set anywhere, yet the macro is present.

These looks like they can be safely removed.

JablonskiMateusz commented 9 months ago

Hi @al42and , Thanks for suggestion. Change is merged https://github.com/intel/compute-runtime/commit/3a21b3b2287b5417e21f638e649582ddcedee05a. Can we close the issue now?

al42and commented 9 months ago

Sure!