search

intel / confidential-cloud-native-primitives

The project has been moved to CC-API organization. For more information:
https://github.com/cc-api/confidential-cloud-native-primitives
Apache License 2.0
24 stars 13 forks source link

Update qemu-test.sh #253

Closed wenhuizhang closed 5 months ago

wenhuizhang commented 5 months ago

QEMU command line update:

ruomengh commented 5 months ago

QEMU command line update:

  • change sept-ve-disable to sept-ve-disable=on, sept-ve-disable short form is depracated

This change looks good. Thanks.

  • delete private=on, private=on is not recognizable in qemu 7.0 with tdx-1.0 patches

The script is based on kernel >=6.2 and qemu >=7.2. Instead of making the change, we can keep a separated version for qemu 7.0. What do you think?

wenhuizhang commented 5 months ago

QEMU command line update:

  • change sept-ve-disable to sept-ve-disable=on, sept-ve-disable short form is depracated

This change looks good. Thanks.

  • delete private=on, private=on is not recognizable in qemu 7.0 with tdx-1.0 patches

The script is based on kernel >=6.2 and qemu >=7.2. Instead of making the change, we can keep a separated version for qemu 7.0. What do you think?

That works, hopefully we have something works for Linux v5.15, QEMU 7.0 as well :)

ruomengh commented 5 months ago

QEMU command line update:

  • change sept-ve-disable to sept-ve-disable=on, sept-ve-disable short form is depracated

This change looks good. Thanks.

  • delete private=on, private=on is not recognizable in qemu 7.0 with tdx-1.0 patches

The script is based on kernel >=6.2 and qemu >=7.2. Instead of making the change, we can keep a separated version for qemu 7.0. What do you think?

That works, hopefully we have something works for Linux v5.15, QEMU 7.0 as well :)

Sounds good. I'm going to open another PR to cover the request. Will close this PR if you don't mind.

wenhuizhang commented 5 months ago

QEMU command line update:

  • change sept-ve-disable to sept-ve-disable=on, sept-ve-disable short form is depracated

This change looks good. Thanks.

  • delete private=on, private=on is not recognizable in qemu 7.0 with tdx-1.0 patches

The script is based on kernel >=6.2 and qemu >=7.2. Instead of making the change, we can keep a separated version for qemu 7.0. What do you think?

That works, hopefully we have something works for Linux v5.15, QEMU 7.0 as well :)

Sounds good. I'm going to open another PR to cover the request. Will close this PR if you don't mind.

Thanks, please help close this one;)

ruomengh commented 5 months ago

Close the PR as discussion above.