search

intel / confidential-computing-zoo

Confidential Computing Zoo provides confidential computing solutions based on Intel SGX, TDX, HEXL, etc. technologies.
https://cczoo.readthedocs.io/en/latest/index.html
Apache License 2.0
300 stars 58 forks source link

Fix horizontal_fl/start_container.sh script #212

Closed imlk0 closed 1 year ago

imlk0 commented 1 year ago

Description of the PR

This pr fix a syntax error in bash script cczoo/horizontal_fl/start_container.sh

How to test this PR? 

cd cczoo/horizontal_fl
./start_container.sh ps0 127.0.0.1 ubuntu
imlk0 commented 1 year ago

Please chage elif [ "$4" == "anolisos" ]; then to elif [ "$3" == "anolisos" ]; then, thanks!

Thank you, updated

Hsy-Intel commented 1 year ago

Please chage elif [ "$4" == "anolisos" ]; then to elif [ "$3" == "anolisos" ]; then, thanks!

Thank you, updated

In the best practice document of the Anolis community, the container is not set to run in the background, so in order to be consistent with the document, please remove the '-d' parameter in Anolisos and keep this parameter under Ubuntu. Thanks!

imlk0 commented 1 year ago

In the best practice document of the Anolis community, the container is not set to run in the background, so in order to be consistent with the document, please remove the '-d' parameter in Anolisos and keep this parameter under Ubuntu. Thanks!

Ok, updated. @Hsy-Intel