intel / cri-resource-manager

Kubernetes Container Runtime Interface proxy service with hardware resource aware workload placement policies
Apache License 2.0
176 stars 57 forks source link

pkg/topology: perform colonoscopy on testdata. #1005

Closed klihub closed 1 year ago

klihub commented 1 year ago

While we can use fake go.mod files to prevent golang tooling from descending into test data directories that contain files with a ':' in their name, this is not enough. There are other tools, unfortunately hosted on non-unix OSes, that do not like ':'s in file names. Cloning the repository fails on these and prevents the hosted tools from working at all.

As a workaround, hide offending (test data) files in tarballs and introduce unit test setup and cleanup hooks to extract these tarballs on demand.