search

intel / cri-resource-manager

Kubernetes Container Runtime Interface proxy service with hardware resource aware workload placement policies
Apache License 2.0
176 stars 57 forks source link

github: take golang version from go.mod #1022

Closed marquiz closed 1 year ago

marquiz commented 1 year ago

Fix the verify workflow to actually install the version of Go specified in go.mod. Previously, because of the yaml parsing peculiarities go v1.2 was installed.

Also changes the order of steps so that go.mod is available.

NOTE: This expects that the practice from now on is to keep the Go version in go.mod and Makefile in sync.

codecov-commenter commented 1 year ago

Codecov Report

Merging #1022 (b5128e8) into master (0baf03f) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1022   +/-   ##
=======================================
  Coverage   31.86%   31.86%           
=======================================
  Files          65       65           
  Lines        9835     9835           
=======================================
  Hits         3134     3134           
  Misses       6411     6411           
  Partials      290      290

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

marquiz commented 1 year ago

Changed the PR to do what @mythi suggested i.e. take Go version from the go.mod file. I think this is the least error-prone method for us, keeping the golang version in sync everywhere