Closed klihub closed 10 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
cfe4bc2
) 32.12% compared to head (3ffff03
) 32.12%. Report is 7 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
LGTM
I suppose this is something to be emphasized in release notes... CRI-RM 0.9 requires Kubernetes 1.23+ and containerd 1.6+ or something.
Yes, definitely.
@klihub please rebase and let's see how it goes. I think this would be "Ready for review" 😊
Or should we wait for #1079?
@marquiz, @askervin I think merging this requires/warrants rerunning the end-to-end tests.
I think merging this requires/warrants rerunning the end-to-end tests.
Fair point
I think merging this requires/warrants rerunning the end-to-end tests.
Fair point
Okay, with the latest commit at the tip, all tests pass.
Okay, with the latest commit at the tip, all tests pass.
Yeah, same here.
LGTM
This patch set
Note that relaying for the streaming PLEG/GetContainerEvents interface is not implemented.