intel / cri-resource-manager

Kubernetes Container Runtime Interface proxy service with hardware resource aware workload placement policies
Apache License 2.0
176 stars 57 forks source link

docs: update the govm setup instructions #1110

Closed marquiz closed 2 months ago

marquiz commented 2 months ago

We're not compatible with the latest govm.

marquiz commented 2 months ago

After fighting with this on a fresh dev machine I decided to update the docs...

klihub commented 2 months ago

I again mixed up PRs. My following comment the other day was about this PR, so I repeat it here:

It is this commit which breaks govm for us. With that commit in place I see docker log messages which suggest that the content of cloud-init user-data is also being interpreted as a/the docker volume specification...

marquiz commented 2 months ago

ping @askervin @klihub

klihub commented 2 months ago

ping @askervin @klihub

I'm fine with this if we get the lost job running and the CI test to pass so we can merge this.

marquiz commented 2 months ago

verify / build-and-test is not run for docs-only PR. I don't understand why it picked that in this PR