intel / cri-resource-manager

Kubernetes Container Runtime Interface proxy service with hardware resource aware workload placement policies
Apache License 2.0
176 stars 57 forks source link

[release-0.8] cpuallocator: fix cpu priority discovery #978

Closed marquiz closed 1 year ago

marquiz commented 1 year ago

The CPU priorities were discovered correctly but not stored in the cpuallocator so they were effectively discarded.

(cherry picked from commit daa821d5bdd9bba6a2e3e810d06f2b79b1fb9604)

Backports #971

codecov-commenter commented 1 year ago

Codecov Report

Merging #978 (46ddbbd) into release-0.8 (7d464f9) will decrease coverage by 1.73%. The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           release-0.8     #978      +/-   ##
===============================================
- Coverage        33.68%   31.95%   -1.73%     
===============================================
  Files               61       65       +4     
  Lines             9156     9835     +679     
===============================================
+ Hits              3084     3143      +59     
- Misses            5789     6404     +615     
- Partials           283      288       +5     
Impacted Files Coverage Δ
pkg/cpuallocator/allocator.go 48.32% <100.00%> (+0.15%) :arrow_up:
pkg/cgroups/cgroupstats.go 0.00% <0.00%> (ø)
...source-manager/policy/builtin/dynamic-pools/cpu.go 0.00% <0.00%> (ø)
...ce-manager/policy/builtin/dynamic-pools/metrics.go 0.00% <0.00%> (ø)
...urce-manager/policy/builtin/dynamic-pools/flags.go 46.42% <0.00%> (ø)
...source-manager/policy/builtin/dynamic-pools/dyp.go 9.35% <0.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

marquiz commented 1 year ago

Plz push the merge button 🥺