search

intel / cryptography-primitives

Apache License 2.0
318 stars 86 forks source link

Remove BoringSSL-specific definition of BN_bn2lebinpad #63

Closed dgpc closed 8 months ago

dgpc commented 1 year ago

Envoy is trying to upgrade its BoringSSL dependency (https://github.com/envoyproxy/envoy/pull/30001), and we need to remove this BoringSSL-specific re-definition of BN_bn2lebinpad, since this was introduced to BoringSSL directly in https://boringssl.googlesource.com/boringssl/+/004317217f81b14c764748f42c5ea88fd05fea3c

ElenaTyuleneva commented 11 months ago

Hi @dgpc , thanks for the proposed changes! Could you please specify which version of BoringSSL you are upgrading to (preferably with the exact links to BoringSSL repo)?

soulxu commented 11 months ago

@ElenaTyuleneva envoy is upgrade to this version https://github.com/envoyproxy/envoy/pull/30001/files#diff-a2ca502474bb8ec5f092176f7ee6d2f11fc395ebb00e1717d6fbad9b16ee8fd8R124

ElenaTyuleneva commented 11 months ago

@soulxu , thank you for the info. To support this change we need to also move our internal validation to the newer version of BoringSSL, it requires us some amount of time to do that.

ElenaTyuleneva commented 8 months ago

Hello @dgpc , @soulxu , your PR with fixes has been merged to the internal IPP Crypto repository.

According to our Contribution guide I'm closing this PR. The support of the newer version of BoringSSL will be available in the next IPP Crypto release.

Thank you for your contribution!