search

intel / cve-bin-tool

The CVE Binary Tool helps you determine if your system includes known vulnerabilities. You can scan binaries for over 200 common, vulnerable components (openssl, libpng, libxml2, expat and others), or if you know the components used, you can get a list of known vulnerabilities associated with an SBOM or a list of components and versions.
https://cve-bin-tool.readthedocs.io/en/latest/
GNU General Public License v3.0
1.23k stars 464 forks source link

fix: TypeError in fuzz_python_requirement_parser in fuzzing reports #… #4312

Closed hassaanshafqatt closed 3 months ago

hassaanshafqatt commented 3 months ago

fixes #4053

terriko commented 3 months ago

Note to self: needs black fixes before merge (I can and will do that after lunch, but I'm flagging this for myself so I don't forget.)

hassaanshafqatt commented 3 months ago

You're welcome and as this is my first contribution here, Would you consider commenting a bit on what this black issue is? I did some research on my end but couldn't get an exact answer.

Thank you.

terriko commented 3 months ago

Black is an auto-formatter we use in place of a style guide to make our code more consistent with the PEP8 python style guide. You can read all about the various linters we use here: https://cve-bin-tool.readthedocs.io/en/latest/CONTRIBUTING.html#running-linters

Since black will auto-format your code, you can just do the following to fix any error it's complaining about once you have black installed:

black <filename>
git add <filename>
git commit -m "chore: fix black issues"
git push <your branch>

I'll leave this open and unmerged for a bit in case you want to just try that yourself! Otherwise I'll sort out the fixes tomorrow and merge it then.

hassaanshafqatt commented 3 months ago

Sure, I'm on it.

hassaanshafqatt commented 3 months ago

Followed your instructions, I hope that fixes it.

terriko commented 3 months ago

All good! Thank you again!